Примеры ошибок, обнаруженных с помощью диагностики V3021

V3021. There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless.

Stride

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless. GraphViewModel.cs 40


private GraphViewModel(....) : base(serviceProvider)
{
  ....
  if (rootPresenters == null)
    throw new ArgumentNullException(nameof(rootPresenters));
  ....
  if (rootPresenters == null)
    throw new ArgumentNullException(nameof(rootNode));
  ....
}

Stride


internal IObjectNode SetTarget(....)
{
  if (....)
  {
    var targetValue = targetNode.Retrieve();

    if (targetValue != null && !type.IsInstanceOfType(targetValue))
      throw new InvalidOperationException(@"The type of the retrieved" +
                                           "node content does not match" +
                                           "the type of this reference");

    if (targetValue != null && !type.IsInstanceOfType(targetValue))
      throw new InvalidOperationException("TargetNode type does not " +
                                          "match the reference type.");

    ....
  }
  ....
}

MonoDevelop


public override void VisitIndexerExpression(
                      IndexerExpression indexerExpression)
{
  ....
  var localResolveResult = context.Resolve(
                             indexerExpression.Target)
                           as LocalResolveResult;
  if (localResolveResult == null)
    return;
  var resolveResult = context.Resolve(indexerExpression);
  if (localResolveResult == null)
    return;
  ....
}

MonoDevelop


bool TryRemoveTransparentIdentifier(....)
{
  ....
  string nae1Name = ExtractExpressionName(ref nae1);
  if (nae1Name == null)
    return false;

  ....
  string nae2Name = ExtractExpressionName(ref nae2);
  if (nae1Name == null)
    return false;

  ....
}

ML.NET


private protected override void CheckOptions(IChannel ch)
{
  ....
  if (FastTreeTrainerOptions.NumberOfLeaves > 2 &&
      FastTreeTrainerOptions.HistogramPoolSize >
      FastTreeTrainerOptions.NumberOfLeaves - 1)
  {
    throw ch.Except("Histogram pool size (ps) must be at least 2.");
  }

  if (FastTreeTrainerOptions.NumberOfLeaves > 2 &&
      FastTreeTrainerOptions.HistogramPoolSize >
      FastTreeTrainerOptions.NumberOfLeaves - 1)
  {
    throw ch.Except("Histogram pool size (ps) must be at most numLeaves - 1.");
  }
  ....
}

MonoDevelop


public static SW.FontWeight
  ToWpfFontWeight (this FontWeight value)
{
  if (value == FontWeight.Thin)
    return SW.FontWeights.Thin;
  if (value == FontWeight.Ultralight)
    return SW.FontWeights.UltraLight;
  if (value == FontWeight.Light)
    return SW.FontWeights.Light;
  if (value == FontWeight.Semilight)
    return SW.FontWeights.Light;
  if (value == FontWeight.Book)  // <=
    return SW.FontWeights.Normal;
  if (value == FontWeight.Medium)
    return SW.FontWeights.Medium;
  if (value == FontWeight.Semibold)
    return SW.FontWeights.SemiBold;
  if (value == FontWeight.Bold)
    return SW.FontWeights.Bold;
  if (value == FontWeight.Ultrabold)
    return SW.FontWeights.UltraBold;
  if (value == FontWeight.Heavy)
    return SW.FontWeights.Black;
  if (value == FontWeight.Ultraheavy)
    return SW.FontWeights.UltraBlack;

  return SW.FontWeights.Normal;
}

public enum FontWeight
{
  /// The thin weight (100)
  Thin = 100,
  /// The ultra light weight (200)
  Ultralight = 200,
  /// The light weight (300)
  Light = 300,
  /// The semi light weight (350)
  Semilight = 350,
  /// The book weight (380)
  Book = 350,
  ....
}

MonoDevelop


public override object GetData (TransferDataType type)
{
  if (type == TransferDataType.Text)
    return clipboard.WaitForText ();
  if (type == TransferDataType.Text)
    return clipboard.WaitForImage ();
  ....
}

IronPython and IronRuby

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless. cPickle.cs 2194


private void LoadNewObj(CodeContext/*!*/ context) {
  PythonTuple args = PopStack() as PythonTuple;
  if (args == null) {
    throw PythonOps.TypeError(
      "expected second argument, got {0}",
      DynamicHelpers.GetPythonType(args));
  }
  PythonType cls = PopStack() as PythonType;
  if (args == null) {
    throw PythonOps.TypeError(
      "expected first argument, got {0}",
      DynamicHelpers.GetPythonType(args));
  }
  ....
}

IronPython and IronRuby


public static int Compare(SourceLocation left,
                          SourceLocation right) {
  if (left < right) return -1;
  if (right > left) return 1;
  return 0;
}

.NET Compiler Platform ("Roslyn")


internal static bool ReportConflictWithParameter(....)
{
  ....
  if (newSymbolKind == SymbolKind.Parameter ||
      newSymbolKind == SymbolKind.Local)
  {
    diagnostics.Add(ErrorCode.ERR_LocalSameNameAsTypeParam,
                    newLocation, name);
    return true;
  }
  if (newSymbolKind == SymbolKind.TypeParameter)
  {
    return false;
  }
  if (newSymbolKind == SymbolKind.Parameter ||
      newSymbolKind == SymbolKind.Local)
  {
    diagnostics.Add(ErrorCode.ERR_LocalSameNameAsTypeParam,
                    newLocation, name);
    return true;
  }
  ....
}

Similar errors can be found in some other places:

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless WithLambdaParametersBinder.cs 131

Accord.Net


public void Fit(double[][] observations,
                double[] weights,
                MultivariateEmpiricalOptions options)
{
  if (weights != null)
    throw new ArgumentException(
      "This distribution does not support weighted  samples.",
      "weights");
  ....
  if (weights != null)
      weights = inPlace ? weights : (double[])weights.Clone();
  ....
}

Similar errors can be found in some other places:

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless Accord.Statistics MultivariateEmpiricalDistribution.cs 687

Old NASA World Wind (C#)

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless HtmlEditor.cs 1480


public void LoadUrl(String url)
{
  ....
  if (!isCreated)
  {
    Debug.WriteLine("Doc not created" +
                    iLoadAttempts.ToString());
    if (iLoadAttempts < 2)
    {
      this.bLoadUrlWhenReady = true;
      return;
    }
    else
    {
      throw new HtmlEditorException("Document not created");
    }
  }

  if (!isCreated) return; // <=
  ....
}

Unity3D


public static Material Add(....)
{
  ....
  if (!baseMat.HasProperty("_StencilReadMask"))
  {
    Debug.LogWarning(".... _StencilReadMask ....", baseMat);
    return baseMat;
  }
  if (!baseMat.HasProperty("_StencilReadMask")) // <=
  {
    Debug.LogWarning(".... _StencilWriteMask ....", baseMat);
    return baseMat;
  }
  ....
}

Mono


public int LastIndexOfAny (char [] anyOf,
                           int startIndex,
                           int count)
{
  ....
  if (this.m_stringLength == 0)
    return -1;

  ....
  if (this.m_stringLength == 0)
    return -1;

  ....
}

Mono


private PaperKind GetPaperKind (int width, int height)
{
  ....
  if (width == 1100 && height == 1700)
    return PaperKind.Standard11x17;
  ....
  if (width == 1100 && height == 1700)
    return PaperKind.Tabloid;
  ....
}

Similar errors can be found in some other places:

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless. Mono.Data.Sqlite-net_4_x SQLiteDataReader.cs 270
V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless. System.Web-net_4_x HttpUtility.cs 220
V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless., System.Design-plaindesign-net_4_x CodeDomComponentSerializationService.cs 562
And 1 additional diagnostic messages.

Mono


private void SerializeCore (SerializationStore store,
                            object value, bool absolute)
{
  if (value == null)
    throw new ArgumentNullException ("value");
  if (store == null)                            // <=
    throw new ArgumentNullException ("store");

  CodeDomSerializationStore codeDomStore =
    store as CodeDomSerializationStore;
  if (store == null)                            // <=
    throw new InvalidOperationException (
                "store type unsupported");

  codeDomStore.AddObject (value, absolute);
}

SharpDevelop


public int Compare(SharpTreeNode x, SharpTreeNode y)
{
  ....
  if (typeNameComparison == 0) {
    if (x.Text.ToString().Length < y.Text.ToString().Length)
      return -1;
    if (x.Text.ToString().Length < y.Text.ToString().Length)
      return 1;
  }
  ....
}

Logify Alert Clients

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless Program.cs 159


bool ValidateConfiguration(SenderConfiguration config) {
  if (String.IsNullOrEmpty(config.Url)) {
      Console.WriteLine("ERROR: service Url not specified");
      return false;
  }
  if (String.IsNullOrEmpty(config.ApiKey)) {
      Console.WriteLine("ERROR: ApiKey not specified");
      return false;
  }
  if (String.IsNullOrEmpty(config.ApiKey)) {
      Console.WriteLine("ERROR: ReportFileName not specified");
      return false;
  }
  ....
}

Unity C# reference source code

V3021 CWE-561 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless CustomScriptAssembly.cs 179


public bool IsCompatibleWith(....)
{
  ....
  if (buildingForEditor)
    return IsCompatibleWithEditor();

  if (buildingForEditor)
    buildTarget = BuildTarget.NoTarget; // Editor
  ....
}

.NET Core Libraries (CoreFX)


private int ReadOldRowData(
  DataSet ds, ref DataTable table, ref int pos, XmlReader row)
{
  ....
  if (table == null)
  {
    row.Skip();
    return -1;
  }
  ....

  if (table == null)
    throw ExceptionBuilder.DiffgramMissingTable(
            XmlConvert.DecodeName(row.LocalName));
  ....
}

OpenCvSharp

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless InputArray.cs 394


private static MatType EstimateType(Type t)
{
  ....
  if (t == typeof(Vec2b))
    return MatType.CV_8UC2;
  if (t == typeof(Vec3b))
    return MatType.CV_8UC3;
  if (t == typeof(Vec4b))
    return MatType.CV_8UC4;
  if (t == typeof(Vec6b))
    return MatType.CV_8UC(6);
  if (t == typeof(Vec2s))         // <=
    return MatType.CV_16SC2;
  ....
  if (t == typeof(Vec2s))         // <=
    return MatType.CV_32SC2;
  ....
}

OpenCvSharp

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless Cv2_calib3d.cs 1370


public static double CalibrateCamera(....)
{
  if (objectPoints == null)
    throw new ArgumentNullException(nameof(objectPoints));
  if (objectPoints == null)
    throw new ArgumentNullException(nameof(objectPoints));
  ....
}

Also see V3022

Similar errors can be found in some other places:

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless Cv2_calib3d.cs 1444

Emby

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless SkiaEncoder.cs 537


public string EncodeImage(string inputPath,
                          DateTime dateModified,
                          string outputPath,
                          bool autoOrient,
                          ImageOrientation? orientation,
                          int quality,
                          ImageProcessingOptions options,
                          ImageFormat selectedOutputFormat)
{
  if (string.IsNullOrWhiteSpace(inputPath))
  {
      throw new ArgumentNullException("inputPath");
  }
  if (string.IsNullOrWhiteSpace(inputPath))
  {
      throw new ArgumentNullException("outputPath");
  }
  ....
}

Nethermind


public void Setup()
{
  if (_decoderBuffer.ReadableBytes > 0)
  {
    throw new Exception("decoder buffer");
  }

  if (_decoderBuffer.ReadableBytes > 0)
  {
    throw new Exception("decoder buffer");
  }
  ....
}

ONLYOFFICE Community Server

V3021 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains method return. This means that the second 'if' statement is senseless WikiEngine.cs 688


private static LinkType CheckTheLink(string str, out string sLink)
{
    sLink = string.Empty;

    if (string.IsNullOrEmpty(str))
        return LinkType.None;

    if (str[0] == '[')
    {
        sLink = str.Trim("[]".ToCharArray()).Split('|')[0].Trim();
    }
    else if (....)
    {
        sLink = str.Split('|')[0].Trim();
    }
    sLink = sLink.Split('#')[0].Trim();    // <=
    if (string.IsNullOrEmpty(str))         // <=
        return LinkType.None;

    if (sLink.Contains(":"))
    {
      ....
    }
    ....
}

Umbraco


public static string ToXmlString(this object value, Type type)
{
  ....
  if (type == typeof(bool)) return XmlConvert.ToString((bool)value);
  ....
  if (type == typeof(bool)) return XmlConvert.ToString((bool)value);
  ....
}

.NET 6 libraries


internal DeflateManagedStream(Stream stream,
                              ZipArchiveEntry.CompressionMethodValues method,
                              long uncompressedSize = -1)
{
  if (stream == null)
    throw new ArgumentNullException(nameof(stream));
  if (!stream.CanRead)
    throw new ArgumentException(SR.NotSupported_UnreadableStream,
                                nameof(stream));
  if (!stream.CanRead)
    throw new ArgumentException(SR.NotSupported_UnreadableStream,
                                nameof(stream));

  ....
}

.NET 6 libraries


public static object? Deserialize(ReadOnlySpan<char> json,
                                  Type returnType,
                                  JsonSerializerOptions? options = null)
{
  // default/null span is treated as empty
  if (returnType == null)
  {
    throw new ArgumentNullException(nameof(returnType));
  }

  if (returnType == null)
  {
    throw new ArgumentNullException(nameof(returnType));
  }

  JsonTypeInfo jsonTypeInfo = GetTypeInfo(options, returnType);
  return ReadFromSpan<object?>(json, jsonTypeInfo)!;
}

.NET 6 libraries


private void WriteQualifiedNameElement(....)
{
  bool hasDefault = defaultValue != null && defaultValue != DBNull.Value;
  if (hasDefault)
  {
    throw Globals.NotSupported(
      "XmlQualifiedName DefaultValue not supported.  Fail in WriteValue()");
  }
  ....
  if (hasDefault)
  {
    throw Globals.NotSupported(
      "XmlQualifiedName DefaultValue not supported.  Fail in WriteValue()");
  }
}

Barotrauma


private static void InitProjectSpecific()
{
  ....
  AssignOnClientRequestExecute(
    "setclientcharacter",
    (Client senderClient, Vector2 cursorWorldPos, string[] args) =>
    {
      if (args.Length < 2)
      {
        GameMain.Server.SendConsoleMessage("....", senderClient);
        return;
      }

      if (args.Length < 2)
      {
        ThrowError("....");
        return;
      }
    );
  ....
}

GrandNode


public enum SKEncodedImageFormat
{
 ....
 Wbmp = 5,
 Webp = 6,
 ....
}

protected SKEncodedImageFormat EncodedImageFormat(string mimetype)
{
 SKEncodedImageFormat defaultFormat = SKEncodedImageFormat.Jpeg;
 if (string.IsNullOrEmpty(mimetype))
  return defaultFormat;

 mimetype = mimetype.ToLower();
 if (   mimetype.Contains("jpeg")
     || mimetype.Contains("jpg")
     || mimetype.Contains("pjpeg"))
  return defaultFormat;

 if (mimetype.Contains("png"))
  return SKEncodedImageFormat.Png;

 if (mimetype.Contains("webp"))      // <=
  return SKEncodedImageFormat.Webp;

 if (mimetype.Contains("webp"))      // <=
  return SKEncodedImageFormat.Webp;

 if (mimetype.Contains("gif"))
  return SKEncodedImageFormat.Gif;

 //if mime type is BMP format then happens error with convert picture
 if (mimetype.Contains("bmp"))
  return SKEncodedImageFormat.Png;

 if (mimetype.Contains("ico"))
  return SKEncodedImageFormat.Ico;

 return defaultFormat;
}

Примеры ошибок, обнаруженных с помощью диагностики V3021

Stride

Stride

MonoDevelop

MonoDevelop

ML.NET

MonoDevelop

MonoDevelop

IronPython and IronRuby

IronPython and IronRuby

.NET Compiler Platform ("Roslyn")

Accord.Net

Old NASA World Wind (C#)

Unity3D

Mono

Mono

Mono

SharpDevelop

Logify Alert Clients

Unity C# reference source code

.NET Core Libraries (CoreFX)

OpenCvSharp

OpenCvSharp

Emby

Nethermind

ONLYOFFICE Community Server

Umbraco

.NET 6 libraries

.NET 6 libraries

.NET 6 libraries

Barotrauma

GrandNode

Заполните форму в два простых шага ниже:

Ваши контактные данные:

Тип желаемой лицензии:

Хотите получить ключ на использование анализатора в пробный период?

Достижения

PVS-Studio

Лицензирование

Компания