Примеры ошибок, обнаруженных с помощью диагностики V6013

V6013. Comparison of arrays, strings, collections by reference. Possibly an equality comparison was intended.

Elasticsearch

V6013 Numbers 'displaySize' and 'that.displaySize' are compared by reference. Possibly an equality comparison was intended. ColumnInfo.java(122)

....
private final String table;
private final String name;
private final String esType;
private final Integer displaySize;
....
@Override
public boolean equals(Object o) {
    if (this == o) {
        return true;
    }
    if (o == null || getClass() != o.getClass()) {
        return false;
    }
    ColumnInfo that = (ColumnInfo) o;
    return displaySize == that.displaySize &&    // <=
           Objects.equals(table, that.table) &&
           Objects.equals(name, that.name) &&
           Objects.equals(esType, that.esType);
}

jBullet

V6013 Strings 'child.name' and 'name' are compared by reference. Possibly an equality comparison was intended. CProfileNode.java(70)

public CProfileNode getSubNode(String name) {
  // Try to find this sub node
  CProfileNode child = this.child;
  while (child != null) {
    if (child.name == name) {          // <=
      return child;
    }
    child = child.sibling;
  }

  // We didn't find it, so add it
  ....
  return node;
}

Keycloak

V6013 Strings 'action' and 'key.action' are compared by reference. Possibly an equality comparison was intended. UserRequiredActionEntity.java 99

public boolean equals(Object o) {
  if (this == o) return true;
  if (o == null || getClass() != o.getClass()) return false;

  Key key = (Key) o;

  if (action != key.action) return false;         // <=
  ....
}

Apache Solr

V6013 Objects 'docValues' and 'other.docValues' are compared by reference. Possibly an equality comparison was intended. TestFieldCacheSortRandom.java 341

private static class RandomQuery extends Query {
  private final long seed;
  private float density;
  private final List<BytesRef> docValues;
  ....
  private boolean equalsTo(RandomQuery other) {
    return seed == other.seed &&
           docValues == other.docValues &&
           density == other.density;
  }
}

Elasticsearch

V6013 Objects 'newValues' and 'values' are compared by reference. Possibly an equality comparison was intended. ConcatFunctionPipe.java 41

private final List values;
....
@Override
public final Pipe resolveAttributes(AttributeResolver resolver) {
    List newValues = new ArrayList<>(values.size());
    for (Pipe v : values) {
        newValues.add(v.resolveAttributes(resolver));
    }
    if (newValues == values) {  // <=
        return this;
    }
    return replaceChildrenSameSize(newValues);
}

WorldWind Java

V6013 Arrays 'buf' and '_nameCopyBuffer' are compared by reference. Possibly an equality comparison was intended. IOContext.java 234

public void releaseNameCopyBuffer(char[] buf)
{
  if (buf != null) {
    if (buf != _nameCopyBuffer) {                    // <=
      throw new IllegalArgumentException(....);
    }
    ....
  }
}